cloud-fan commented on a change in pull request #24618:
[SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill
URL: https://github.com/apache/spark/pull/24618#discussion_r402792501
##########
File path:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java
##########
@@ -416,6 +428,7 @@ public void insertRecord(Object recordBase, long
recordOffset, int length, int p
Platform.copyMemory(recordBase, recordOffset, base, pageCursor, length);
pageCursor += length;
inMemSorter.insertRecord(recordAddress, partitionId);
+ inMemRecordsSize += length;
Review comment:
+1, the `pageCursor` is also increased by uaoSize and length
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
