rednaxelafx commented on a change in pull request #28081: [SPARK-31315][SQL]
SQLQueryTestSuite: Display the total compile time for generated java code
URL: https://github.com/apache/spark/pull/28081#discussion_r402874997
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1309,6 +1309,23 @@ object CodeGenerator extends Logging {
// bytecode instruction
final val MUTABLESTATEARRAY_SIZE_LIMIT = 32768
+ // The java source code generated by whole codegen is compiled on the Driver
side and sent to
Review comment:
Hi @beliefer ,
I'm really sorry to post edit suggestions after the PR is merged. I noticed
this PR just now...
If we have a chance to make follow-up changes, could you please update `java
code` to `Java code`, and `whole codegen` to `whole-stage codegen`?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
