dongjoon-hyun commented on a change in pull request #27836: [SPARK-31009][SQL] Support json_object_keys function URL: https://github.com/apache/spark/pull/27836#discussion_r403507849
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala ########## @@ -796,3 +797,71 @@ case class SchemaOfJson( override def prettyName: String = "schema_of_json" } + +/** + * A function which returns all the keys of outer JSON object. Review comment: Since JSON can have a nested structure with multiple `inner`s and `outer`s, shall we use `the outmost` instead of `outer`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
