surajiyer edited a comment on issue #28110: [SPARK-31339][WIP] L245: Changed PipelineModel(...) to self.cls(...) URL: https://github.com/apache/spark/pull/28110#issuecomment-609420311 > Would you maybe just override the reader, if you have a custom impl? I could but the implementation I am working on is simple and the serialization logic is meant to be the same. In fact, it also does not generally make sense to me that a custom implementation when deserialized loads as a PipelineModel instead of the custom class. If I call save() on my custom class, I also expect the load() to return an object of that class. Edit: Also I searched if there are other readers like this. All other classes that inherit MLWritable/MLReadable call their Scala counterpart.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
