Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3916#discussion_r26080561
  
    --- Diff: sbin/spark-daemon.sh ---
    @@ -121,45 +121,63 @@ if [ "$SPARK_NICENESS" = "" ]; then
         export SPARK_NICENESS=0
     fi
     
    +run_command() {
    +  mode=$1
    +  shift
     
    -case $option in
    -
    -  (start|spark-submit)
    -
    -    mkdir -p "$SPARK_PID_DIR"
    +  mkdir -p "$SPARK_PID_DIR"
     
    -    if [ -f $pid ]; then
    -      TARGET_ID="$(cat "$pid")"
    -      if [[ $(ps -p "$TARGET_ID" -o args=) =~ $command ]]; then
    -        echo "$command running as process $TARGET_ID.  Stop it first."
    -        exit 1
    -      fi
    +  if [ -f $pid ]; then
    +    TARGET_ID="$(cat "$pid")"
    +    if [[ $(ps -p "$TARGET_ID" -o args=) =~ $command ]]; then
    +      echo "$command running as process $TARGET_ID.  Stop it first."
    +      exit 1
         fi
    +  fi
     
    -    if [ "$SPARK_MASTER" != "" ]; then
    -      echo rsync from "$SPARK_MASTER"
    -      rsync -a -e ssh --delete --exclude=.svn --exclude='logs/*' 
--exclude='contrib/hod/logs/*' $SPARK_MASTER/ "$SPARK_HOME"
    -    fi
    +  if [ "$SPARK_MASTER" != "" ]; then
    +    echo rsync from "$SPARK_MASTER"
    +    rsync -a -e ssh --delete --exclude=.svn --exclude='logs/*' 
--exclude='contrib/hod/logs/*' $SPARK_MASTER/ "$SPARK_HOME"
    --- End diff --
    
    ```
    "$SPARK_MASTER/"
    ```
    
    Unless this variable should potentially be interpreted as multiple 
arguments to `rsync`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to