HyukjinKwon commented on a change in pull request #28133: [SPARK-31156][SQL] 
DataFrameStatFunctions API to be consistent with respect to Column type
URL: https://github.com/apache/spark/pull/28133#discussion_r403815095
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala
 ##########
 @@ -69,10 +69,10 @@ final class DataFrameStatFunctions private[sql](df: 
DataFrame) {
    * @since 2.0.0
    */
   def approxQuantile(
-      col: String,
+      colName: String,
 
 Review comment:
   ```
   [error] 
/home/jenkins/workspace/SparkPullRequestBuilder/sql/core/target/java/org/apache/spark/sql/DataFrameStatFunctions.java:27:
 error: @param name not found
   [error]    * @param col the name of the numerical column
   [error]             ^
   ```
   
   Doc generation is being failed due to mismatched naming here. I think you 
don't have to rename it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to