surajiyer commented on a change in pull request #28110: [SPARK-31339][WIP]
L245: Changed PipelineModel(...) to self.cls(...)
URL: https://github.com/apache/spark/pull/28110#discussion_r403869680
##########
File path: python/pyspark/ml/pipeline.py
##########
@@ -242,7 +242,7 @@ def load(self, path):
return JavaMLReader(self.cls).load(path)
else:
uid, stages = PipelineSharedReadWrite.load(metadata, self.sc, path)
- return PipelineModel(stages=stages)._resetUid(uid)
+ return self.cls(stages=stages)._resetUid(uid)
Review comment:
Is that mandatory? It seems strange that the intention is to force
developers to inherit all three together even when the Reader/Writer logic is
the same for the custom implementation of the `PipelineModel`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
