beliefer commented on a change in pull request #28134: [SPARK-31358][SQL][DOC]
Document FILTER clauses of aggregate functions in SQL references
URL: https://github.com/apache/spark/pull/28134#discussion_r404131336
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -70,6 +76,19 @@ GROUP BY GROUPING SETS (grouping_set [ , ...])
((warehouse, product), (warehouse), (product), ())</code>.
The N elements of a <code>CUBE</code> specification results in 2^N
<code>GROUPING SETS</code>.
</dd>
+ <dt><code><em>aggregate_name</em></code></dt>
+ <dd>
+ Specifies an aggregate function name (MIN, MAX, COUNT, SUM, AVG, etc.).
+ </dd>
+ <dt><code><em>DISTINCT</em></code></dt>
+ <dd>
+ Removes duplicates in input rows before they are passed to aggregate
functions.
+ </dd>
+ <dt><code><em>FILTER</em></code></dt>
+ <dd>
+ Filters the input rows for which the <code>boolean_expression</code> in
the <code>WHERE</code> clause evaluates
Review comment:
Could we change <code>WHERE</code> to <code>FILTER</code>.
Because `WHERE clause` causes confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
