rdblue commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax URL: https://github.com/apache/spark/pull/28026#issuecomment-609905547 You're right that options _could_ be done as a separate commit. The other, not so much. In both cases, consider how much of this PR actually concerns those changes and you'll see that removing the parts you suggest doesn't actually help make this a smaller change. The option prefix is very small, but an important part of how we pass SERDEPROPERTIES. > Support new statement clauses in ResolveCatalogs conversion to v2 create plans No, this can't be done later. If the clauses are parsed and passed in the statement plan, the conversion to v2 cannot simply ignore them without being a correctness bug. Fixing that correctness bug would be a breaking behavior change. > Add "option." namespace to distinguish SERDEPROPERTIES and OPTIONS in table properties This is an outstanding item that needs to be done before 3.0. A community member volunteered to pick it up and never did and this is a good time to get it done. If we wait until after 3.0, then it will never happen because it will be a breaking change that options are not prefixed when passed to v2 implementations. Not only that, this is how SERDEPROPERTIES _should_ be passed, so changing over the OPTIONS clause in isolation makes little sense.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
