HyukjinKwon commented on issue #28133: [SPARK-31156][SQL] DataFrameStatFunctions API to be consistent with respect to Column type URL: https://github.com/apache/spark/pull/28133#issuecomment-610150206 @kachayev to clarify, are there all instances to fix in `DataFrameStatFunctions` to support `Column` signature? I read the discussion in the JIRA and I don't particularly support this change personally either but I think it makes Spark APIs more consistent considering: https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L58-L60 If these are all instances to fix, I think I am okay. If there are too many to fix, maybe we should just think about another way around e.g., documenting the differences compared to `functions.scala`. WDYT @viirya?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
