jiangxb1987 commented on a change in pull request #28117: [SPARK-31344][CORE]
Polish implementation of barrier() and allGather()
URL: https://github.com/apache/spark/pull/28117#discussion_r404553720
##########
File path: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala
##########
@@ -107,11 +102,11 @@ private[spark] class BarrierCoordinator(
// An Array of RPCCallContexts for barrier tasks that have made a blocking
runBarrier() call
private val requesters: ArrayBuffer[RpcCallContext] = new
ArrayBuffer[RpcCallContext](numTasks)
- // An Array of allGather messages for barrier tasks that have made a
blocking runBarrier() call
- private val allGatherMessages: ArrayBuffer[String] = new
Array[String](numTasks).to[ArrayBuffer]
+ // Messages from each barrier task that have made a blocking runBarrier()
call. And it will be
+ // replied to all tasks once sync finished.
+ private val messages = Array.ofDim[String](numTasks)
- // The blocking requestMethod called by tasks to sync up for this stage
attempt
- private var requestMethodToSync: RequestMethod.Value =
RequestMethod.BARRIER
+ private var requestMethod: RequestMethod.Value = _
Review comment:
nit: add comment to this variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
