turboFei commented on a change in pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task URL: https://github.com/apache/spark/pull/26339#discussion_r405245208
########## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuiteWithSpeculation.scala ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.SparkConf +import org.apache.spark.internal.config +import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.test.SharedSparkSession + +class SQLQuerySuiteWithSpeculation extends QueryTest with SharedSparkSession Review comment: Before set SPECULATION_MULTIPLIER to 0, I could not guarantee a concurrent speculative task could be launched. After set `SPECULATION_MULTIPLIER` to 0 and set `SPECULATION_QUANTILE` to 0.5, I can ensure that some speculative tasks would be launched. Referred to the ut of SPARK-22074: https://github.com/apache/spark/blob/a3d83948b81cb5c47f6e084801373443f54747d8/core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala#L782-L788 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
