gatorsmile commented on a change in pull request #28092: [SPARK-31322][SQL]
rename QueryPlan.collectInPlanAndSubqueries to collectWithSubqueries
URL: https://github.com/apache/spark/pull/28092#discussion_r405713762
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -232,10 +232,10 @@ abstract class QueryPlan[PlanType <:
QueryPlan[PlanType]] extends TreeNode[PlanT
}
/**
- * Returns a sequence containing the result of applying a partial function
to all elements in this
+ * A variant of `collect`. This method not only apply the given function to
all elements in this
* plan, also considering all the plans in its (nested) subqueries
*/
- def collectInPlanAndSubqueries[B](f: PartialFunction[PlanType, B]): Seq[B] =
Review comment:
LGTM
This internal API was added in Spark 3.0 by
https://github.com/apache/spark/pull/25433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
