skambha commented on issue #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow URL: https://github.com/apache/spark/pull/27627#issuecomment-611175398 I have pushed the changes in the latest commit. Please take a look. Thanks. - Uses new DecimalSum implementation - Adds a new analyzer rule and one optimizer rule is updated. - Tests are added for the test scenarios we discussed in this pr so far, and for all the whole stage enabled/disabled, ansi enabled/disabled combinations. _(Sidenote: For now the DecimalSum has the code to handle other types, incase we want to put this logic back into Sum after discussion, if not then we can remove that.)_
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
