maropu commented on issue #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow URL: https://github.com/apache/spark/pull/27627#issuecomment-611287252 > For e.g. Avg aggregate function as part of its implementation uses the Sum expression. So a analyzer rule will not be enough to make the change transparently. We will need to change the avg implementation. Yea, probably, I think we need `DecimalAverage`, too, for the approach. Btw, could you check no performance regression w/ `DecimalSum` for regular non-overflow cases?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
