beliefer commented on a change in pull request #28154: [WIP][SPARK-31372][SQL]
Check the validity of built-in function aliases
URL: https://github.com/apache/spark/pull/28154#discussion_r405929469
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -251,9 +251,9 @@ object FunctionRegistry {
expression[Log10]("log10"),
expression[Log1p]("log1p"),
expression[Log2]("log2"),
- expression[Log]("ln"),
+ expression[Log]("ln", true),
expression[Remainder]("mod", true),
- expression[UnaryMinus]("negative"),
+ expression[UnaryMinus]("negative", true),
Review comment:
@HyukjinKwon This alias should be `negative` or `-` ?
```
spark-sql> desc select negative(1);
(- 1) int NULL
Time taken: 0.035 seconds, Fetched 1 row(s)
```
This alias looks so strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
