iRakson commented on issue #26901: [SPARK-29152][2.4][test-maven]Executor 
Plugin shutdown when dynamic allocation is enabled
URL: https://github.com/apache/spark/pull/26901#issuecomment-611346618
 
 
   @dongjoon-hyun @vanzin 
   Please take a look at this approach for solving this issue.
   Earlier i was adding a shutdown hook in the `executor.scala` which calls 
stop() method of executors.
   
   Instead of adding a shutdown hook, now i am passing `StopExecutor` call to 
executors before killing them. This way they will stop themselves on their own 
before being killed.
   
   I think this approach is better than forcing a shutdown hook.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to