MaxGekk commented on a change in pull request #28166:
[SPARK-31359][DOC][followup] improve code comments in RebaseDateTime
URL: https://github.com/apache/spark/pull/28166#discussion_r406215016
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
##########
@@ -97,51 +105,26 @@ object RebaseDateTime {
-390750, -354226, -317702, -244653, -208129, -171605, -141427)
/**
- * Rebasing days since the epoch to store the same number of days
- * as by Spark 2.4 and earlier versions. Spark 3.0 switched to
- * Proleptic Gregorian calendar (see SPARK-26651), and as a consequence of
that,
- * this affects dates before 1582-10-15. Spark 2.4 and earlier versions use
- * Julian calendar for dates before 1582-10-15. So, the same local date may
- * be mapped to different number of days since the epoch in different
calendars.
+ * Converts the given number of days since the epoch day 1970-01-01 to a
local date in Proleptic
+ * Gregorian calendar, interprets the result as a local date in Julian
calendar, and take the
Review comment:
and take -> and takes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
