maropu commented on a change in pull request #28123: [SPARK-31350][SQL]
Coalesce bucketed tables for join if applicable
URL: https://github.com/apache/spark/pull/28123#discussion_r406559926
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -159,6 +159,14 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
children.foldLeft(Option.empty[BaseType]) { (l, r) => l.orElse(r.find(f)) }
}
+ /**
+ * Tests whether a predicate holds for all nodes.
+ * @param p the predicate function to be applied to each node in the tree.
+ */
+ def forall(p: BaseType => Boolean): Boolean = {
Review comment:
If this method is used only in a single place, could you inline it in the
caller side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
