Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4906#discussion_r26179893
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/Loss.scala
---
@@ -49,4 +49,14 @@ trait Loss extends Serializable {
*/
def computeError(model: TreeEnsembleModel, data: RDD[LabeledPoint]):
Double
+ /**
+ * Method to calculate loss when the predictions are already known.
+ * Note: This method is used in the method evaluateEachIteration to
avoid recomputing the
+ * predicted values from previously fit trees.
+ * @param datum: LabeledPoint
+ * @param prediction: Predicted label.
+ * @return Measure of model error on datapoint.
+ */
+ def computeError(datum: LabeledPoint, prediction: Double) : Double
--- End diff --
switch arg order to match batch computeError more closely
no space before colon (here and elsewhere)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
