beliefer opened a new pull request #28180: [SPARK-31406][SQL][TEST] ThriftServerQueryTestSuite: Sharing test data and test tables among multiple test cases. URL: https://github.com/apache/spark/pull/28180 ### What changes were proposed in this pull request? This PR is related to https://github.com/apache/spark/pull/28060. `ThriftServerQueryTestSuite` spend 17 minutes time to test. I checked the code and found `ThriftServerQueryTestSuite` load test data repeatedly. I've listed all the test cases order by time with desc in the `hive-thriftserver` module below. Class | Spend time ↑ | Failure | Skip | Pass | Total test case -- | -- | -- | -- | -- | -- ThriftServerQueryTestSuite | 17 minutes | 0 | 15 | 140 | 155 CliSuite | 8 minutes 24 seconds | 0 | 0 | 24 | 24 SparkThriftServerProtocolVersionsSuite | 59 seconds | 0 | 0 | 210 | 210 HiveThriftBinaryServerSuite | 36 seconds | 0 | 1 | 21 | 22 SparkMetadataOperationSuite | 19 seconds | 0 | 0 | 7 | 7 HiveCliSessionStateSuite | 16 seconds | 0 | 0 | 2 | 2 SparkSQLEnvSuite | 16 seconds | 0 | 0 | 1 | 1 HiveThriftHttpServerSuite | 15 seconds | 0 | 0 | 3 | 3 SingleSessionSuite | 14 seconds | 0 | 0 | 3 | 3 JdbcConnectionUriSuite | 2.1 seconds | 0 | 0 | 1 | 1 ThriftServerWithSparkContextSuite | 1.4 seconds | 0 | 0 | 1 | 1 SparkExecuteStatementOperationSuite | 63 millseconds | 0 | 0 | 2 | 2 UISeleniumSuite | -1 millseconds | 0 | 1 | 0 | 1 I checked the code of `ThriftServerQueryTestSuite` and found `ThriftServerQueryTestSuite` load test data repeatedly. This PR will improve the performance of `ThriftServerQueryTestSuite`. Because https://github.com/apache/spark/pull/28060 provides `createTestTables`(https://github.com/apache/spark/blob/e42a3945acd614a26c7941a9eed161b500fb4520/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L574) and `removeTestTables`(https://github.com/apache/spark/blob/e42a3945acd614a26c7941a9eed161b500fb4520/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L666), this PR will still uses them. The total time run `ThriftServerQueryTestSuite` before and after this PR show below. Before After ### Why are the changes needed? Improve the performance of `ThriftServerQueryTestSuite`. ### Does this PR introduce any user-facing change? 'No'. ### How was this patch tested? Jenkins test
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
