cloud-fan commented on a change in pull request #28178:
[SPARK-31409][SQL][TEST] Fix failed tests due to result order changing when
enable AQE
URL: https://github.com/apache/spark/pull/28178#discussion_r406716011
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -157,6 +157,8 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
protected override def sparkConf: SparkConf = super.sparkConf
// Fewer shuffle partitions to speed up testing.
.set(SQLConf.SHUFFLE_PARTITIONS, 4)
+ // Disable BHJ optimization to avoid changing result order when we enable
AQE
+ .set(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD, -1.toLong)
Review comment:
This won't reduce test coverage IMO, as we set the broadcast threshold
explicitly when we want to test different physical joins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
