MaxGekk commented on a change in pull request #28172: [SPARK-31402][SQL] Fix
rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#discussion_r407334127
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
##########
@@ -66,15 +66,53 @@ object RebaseDateTime {
// The starting point is the `0001-01-01` (-719164 days since the epoch in
// Julian calendar). All dates before the staring point have the same
difference
// of 2 days in Julian and Proleptic Gregorian calendars.
Review comment:
For this particular array, it is valid comment. It is not valid for
`rebaseJulianToGregorianDays`, strictly speaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
