cloud-fan commented on a change in pull request #28189: [SPARK-31426][SQL] Fix
regressions of toJavaTimestamp/fromJavaTimestamp
URL: https://github.com/apache/spark/pull/28189#discussion_r407339784
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -496,8 +496,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with
Matchers with SQLHelper {
test("2016-03-13 02:00:00", tz, "2016-03-13 10:00:00.0")
test("2016-03-13 03:00:00", tz, "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", tz, "2016-11-06 07:59:59.0")
- test("2016-11-06 01:00:00", tz, "2016-11-06 08:00:00.0")
- test("2016-11-06 01:59:59", tz, "2016-11-06 08:59:59.0")
+ test("2016-11-06 01:00:00", tz, "2016-11-06 09:00:00.0")
Review comment:
as we have looked into the JDK code before, PST is treated as LA. So the
behavior is the same as 2.4, and it's great!
can we highlight it in the `Does this PR introduce any user-facing change?`
section? Say it's changed back to the 2.4 behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
