Ngone51 commented on a change in pull request #28178: [SPARK-31409][SQL][TEST] Fix failed tests due to result order changing when enable AQE URL: https://github.com/apache/spark/pull/28178#discussion_r407381387
########## File path: sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-join.sql ########## @@ -8,6 +8,9 @@ -- -- This test file was converted from postgreSQL/join.sql. +-- Disable BroadcastHashJoin optimization to avoid changing result order when we enable AQE +--SET spark.sql.autoBroadcastJoinThreshold = -1 Review comment: Disable BHJ optimization for the whole `SQLQueryTestSuite` would cause other tests to have different result order and fail. So, I think we could only disable the failed sql query itself instead to reduce the scope, which fix the test as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
