peter-toth commented on issue #28041: [SPARK-30564][SQL] Improved extra new line and comment remove URL: https://github.com/apache/spark/pull/28041#issuecomment-612844144 Hmm, that lightweight solution looks slower than the full-fledged one in this PR and it doesn't help with the second issue: Method splitting can be different, depending on the value of `spark.sql.codegen.comments`. `CodeFormatter. stripExtraNewLinesAndComments` wasn't added for debug purposes in this commit initially: https://github.com/apache/spark/commit/76fb173dd639baa9534486488155fc05a71f850e. We can find a better place for it if necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
