marblejenka commented on a change in pull request #28200: [SPARK-31432][DEPLOY]
bin/sbin scripts should allow to customize jars dir
URL: https://github.com/apache/spark/pull/28200#discussion_r407514314
##########
File path:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java
##########
@@ -328,4 +329,9 @@ static String findJarsDir(String sparkHome, String
scalaVersion, boolean failIfN
return libdir.getAbsolutePath();
}
+ static String getJarsDir(String sparkHome) {
+ String jarsDir = System.getenv(ENV_SPARK_JARS_DIR);
+ return jarsDir != null ? jarsDir : join(File.separator, sparkHome, "jars");
+ }
+
Review comment:
This is because most of the code in launcher put a blank line after the last
method. Shoud I fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
