cloud-fan commented on a change in pull request #28195:
[SPARK-31425][SQL][CORE] UnsafeKVExternalSorter should also respect
UnsafeAlignedOffset
URL: https://github.com/apache/spark/pull/28195#discussion_r407515536
##########
File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java
##########
@@ -706,7 +706,7 @@ public boolean append(Object kbase, long koff, int klen,
Object vbase, long voff
// Here, we'll copy the data into our data pages. Because we only store
a relative offset from
// the key address instead of storing the absolute address of the value,
the key and value
// must be stored in the same memory page.
- // (8 byte key length) (key) (value) (8 byte pointer to next value)
+ // (uao: klen + vlen + uaolen) (uao: klen) (key) (value) (8 byte pointer
to next value)
Review comment:
SGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
