Ngone51 commented on a change in pull request #28085:
[SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests
URL: https://github.com/apache/spark/pull/28085#discussion_r407539294
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1154,6 +1176,7 @@ private[spark] class DAGScheduler(
// Use the scheduling pool, job group, description, etc. from an ActiveJob
associated
// with this Stage
val properties = jobIdToActiveJob(jobId).properties
+ addPysparkConfigsToProperties(stage, properties)
Review comment:
I'm not aware of how `BasePythonRunner` works, but will pyspark properties
propagated from different stages conflict with each other? e.g. stage1 and
stage2 are running concurrently, then, task2.0 may happen to reads task1.0's
properties. Is it possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
