HyukjinKwon commented on a change in pull request #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#discussion_r407829666
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/MaxByAndMinBy.scala
##########
@@ -100,6 +100,9 @@ abstract class MaxMinBy extends DeclarativeAggregate {
""",
since = "3.0.0")
case class MaxBy(valueExpr: Expression, orderingExpr: Expression) extends
MaxMinBy {
+
+ override def prettyName: String = "max_by"
+
override protected def funcName: String = "max_by"
Review comment:
Seems like you can remove this and replace it to `prettyName`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
