srowen commented on a change in pull request #28206: [SPARK-31436][ML] MinHash
keyDistance optimization
URL: https://github.com/apache/spark/pull/28206#discussion_r407840529
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
##########
@@ -70,19 +70,46 @@ class MinHashLSHModel private[ml](
@Since("2.1.0")
Review comment:
I suppose it's protected so a little more visible to callers. I wouldn't
remove it just for its own sake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
