Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/4974#issuecomment-78412319
Hi @srowen Thanks for the suggestions.
1. For adding the `@return` prefix. Sounds fair, and if we're doing it,
shall we change other implementations as well? (like LDA, GaussianMixture and
others).
2. For using foo rather than getFoo, again it may impact a wide range of
code. And shall we change setters to `age_= (value:Int) : this.type` ? @srowen,
@mengxr ,@jkbradley. I'm not sure what's the general recommendation within
Spark. And I'd appreciate if there can be a quick decision from community
leads. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
