cloud-fan commented on issue #28041: [SPARK-30564][SQL] Improved extra new line and comment remove URL: https://github.com/apache/spark/pull/28041#issuecomment-613376751 I would reject to maintain a hand-written parser without significant perf benefits. `stripExtraNewLinesAndComments` shouldn't be used in perf critical code path like `Block.length`, I think making it faster is not the right direction. We should not put comments in the generated code at all. It's hard to avoid new lines in the generated code, but it should be very fast to remove new lines, or at least the hand-written parser can be very simple to only remove new lines. For 3.0, how about we revert https://issues.apache.org/jira/browse/SPARK-21870 first to eliminate the regression? cc @rxin @dongjoon-hyun
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
