cloud-fan commented on a change in pull request #28180:
[SPARK-31406][SQL][TEST] ThriftServerQueryTestSuite: Sharing test data and test
tables among multiple test cases.
URL: https://github.com/apache/spark/pull/28180#discussion_r408160060
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -262,61 +260,6 @@ class ThriftServerQueryTestSuite extends
SQLQueryTestSuite with SharedThriftServ
}
}
- /** Load built-in test tables. */
- private def loadTestData(statement: Statement): Unit = {
- // Prepare the data
- statement.execute(
- """
- |CREATE OR REPLACE TEMPORARY VIEW testdata as
- |SELECT id AS key, CAST(id AS string) AS value FROM range(1, 101)
- """.stripMargin)
Review comment:
or we want to test `executeUpdate` explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
