tgravescs commented on a change in pull request #28085: [SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests URL: https://github.com/apache/spark/pull/28085#discussion_r408184626
########## File path: python/pyspark/resource/executorresourcerequest.py ########## @@ -0,0 +1,73 @@ +# Review comment: I don't think utils is a good example, utils files are generally a bunch of things. Most of the files you mention have 2 classes in them. It seems to be personal preference. So if I make a change, the question is do I put all 6 classes into 1 file, or do I split up by executor, task, and resourceprofile/builder in 3 different files. Again if I'm going to make a change I would like to be clear to not drag this out and have to rework things multiple times. @holdenk any input on this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
