Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4828#issuecomment-78429427
Oh wait. I just realized that there is a already a unit test in
org.apace.spark.streaming.UISuite which tested whether the streaming tab works.
But thats ignored too. Could you update that testsuite to use selenium and test
whether the streaming tab is attached on and detached correctly. I just
realized that the unit tests in the PR tests detaching for tabs, but does not
test whether it works specifically for streaming (suppose the line to detach
gets deleted accidentally in future, no unit test would fail). So please add
the streaming's specific unit test - rename spark.streaming.UISuite to
UISeleniumSuite, and then update test to use selenium.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
