Ngone51 commented on a change in pull request #28195: [SPARK-31425][SQL][CORE]
UnsafeKVExternalSorter/VariableLengthRowBasedKeyValueBatch should also respect
UnsafeAlignedOffset
URL: https://github.com/apache/spark/pull/28195#discussion_r408611757
##########
File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java
##########
@@ -53,7 +53,8 @@
* The map can support up to 2^29 keys. If the key cardinality is higher than
this, you should
* probably be using sorting instead of hashing for better cache locality.
*
- * The key and values under the hood are stored together, in the following
format:
+ * The key and values under the hood are stored together, in the following
format(in case of
+ * uaoSize = 4):
Review comment:
I was supposed to do so but it requires more changes in the original content
and it is not so clean compares to a concrete number. So I am not sure if we
should do. Do you have strong prefer to change in `uaoSize` way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
