maropu commented on a change in pull request #28083: [SPARK-30564][SQL] Revert
Block.length and use comment placeholders in HashAggregateExec
URL: https://github.com/apache/spark/pull/28083#discussion_r409195723
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
##########
@@ -143,10 +143,7 @@ trait Block extends TreeNode[Block] with JavaCode {
case _ => code.trim
}
- def length: Int = {
- // Returns a code length without comments
Review comment:
Ur, one more comment; could you leave some comments here about why the new
logic returns a length with comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
