dongjoon-hyun commented on a change in pull request #28226: [SPARK-31452][SQL]
Do not create partition spec for 0-size partitions in AQE
URL: https://github.com/apache/spark/pull/28226#discussion_r409599179
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -646,12 +678,13 @@ class AdaptiveQueryExecSuite
// Partition 0: both left and right sides are skewed, left side is
divided
// into 2 splits and right side is divided into 4 splits,
so
// 2 x 4 sub-partitions.
- // Partition 1, 2, 3: not skewed, and coalesced into 1 partition.
+ // Partition 1, 2, 3: not skewed, and coalesced into 1 partition, but
it's ignored as the
+ // size is 0.
// Partition 4: only left side is skewed, and divide into 2 splits, so
// 2 sub-partitions.
- // So total (8 + 1 + 3) partitions.
+ // So total (8 + 0 + 3) partitions.
Review comment:
The original statement was wrong: `8 + 1 + 3` -> `8 + 1 + 2`.
So, the new statement should be `8 + 0 + 2` instead of `8 + 0 + 3`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
