cloud-fan commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax URL: https://github.com/apache/spark/pull/28026#issuecomment-614703404 > you can't delegate to a catalog and dictate what makes sense in cases specific to that catalog. I'm not sure I agree. Spark doesn't delegate the SQL string to a catalog literally, it abstract the information from the SQL and passes the information to the catalog. `EXTERNAL` doesn't give you useful information IMO: If it's specified, then `LOCATION` must be specified. If it's not specified, then `LOCATION` shouldn't be specified otherwise it's the same as with `EXTERNAL` specified. I think it's OK to have some decorative works in a language and we can ignore them. I'm OK to treat SERDEPROPERTIES and OPTIONS the same, it's better to have some validation to make sure these two don't conflict. My concern is more about OPTIONS vs TBLPROPERTIES. Are we going to tell end-users that these are just two different ways to specify some configs and the catalog is free to interpret them? Note: I'm asking these because we need to update the SQL reference doc after this PR, which is end-user facing: https://spark.apache.org/docs/3.0.0-preview2/sql-ref-syntax-ddl-create-table.html
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
