cloud-fan commented on a change in pull request #21479: [SPARK-23903][SQL] Add
support for date extract
URL: https://github.com/apache/spark/pull/21479#discussion_r409969409
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -592,6 +592,7 @@ primaryExpression
| identifier
#columnReference
| base=primaryExpression '.' fieldName=identifier
#dereference
| '(' expression ')'
#parenthesizedExpression
+ | EXTRACT '(' field=identifier FROM source=valueExpression ')'
#extract
Review comment:
EXTRACT is not an alias as it has different syntax. The second approach
looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
