skambha edited a comment on issue #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow URL: https://github.com/apache/spark/pull/27627#issuecomment-615038394 @cloud-fan, This is the test case with null rows that showcases the behavior that I mentioned earlier. https://github.com/apache/spark/pull/27627/files#diff-5d2ebf4e9ca5a990136b276859769289R222-R223 -- To be able to distinguish this scenario, one alternative could be to have another flag in addition to the isEmpty flag to keep track of if we saw a non null value - but this would be adding two new flags to the buffer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
