yaooqinn commented on a change in pull request #28197: [SPARK-31431][SQL] Add
CalendarInterval encoder support
URL: https://github.com/apache/spark/pull/28197#discussion_r410023299
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -235,6 +235,7 @@ object ScalaReflection extends ScalaReflection {
case t if isSubtype(t, localTypeOf[java.lang.String]) =>
createDeserializerForString(path, returnNullable = false)
+ case t if isSubtype(t, localTypeOf[CalendarInterval]) => path
Review comment:
with PR https://github.com/apache/spark/pull/28198/files and the existing
logic in `serializerFor`
1.
https://github.com/yaooqinn/spark/blob/6cd0bef7fe872b5d9472a2140db188fb9f1eede8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala#L436
2.
https://github.com/yaooqinn/spark/blob/6cd0bef7fe872b5d9472a2140db188fb9f1eede8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala#L554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
