HyukjinKwon commented on a change in pull request #28238:
[SPARK-23647][PYTHON][SQL][2.4] Adds more types for hint in pyspark
URL: https://github.com/apache/spark/pull/28238#discussion_r410061666
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -506,10 +506,12 @@ def hint(self, name, *parameters):
if not isinstance(name, str):
raise TypeError("name should be provided as str, got
{0}".format(type(name)))
+ allowed_types = (basestring, list, float, int)
Review comment:
BTW, we had to add [`versionchanged`
directive](https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionchanged)
in the docstring too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
