srowen commented on a change in pull request #26319: [SPARK-29594][SQL] Create
a Dataset from a Sequence of Case class where…
URL: https://github.com/apache/spark/pull/26319#discussion_r410252623
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -543,6 +543,12 @@ object ScalaReflection extends ScalaReflection {
throw new UnsupportedOperationException(s"`$fieldName` is a
reserved keyword and " +
"cannot be used as field name\n" + walkedTypePath)
}
+ // It is ok to use head here because a variable name needs to be non
empty
+ if (fieldName.head.isDigit) {
Review comment:
This doesn't catch all cases where a field name causes a problem though. I
think this is too ad hoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
