Ngone51 commented on a change in pull request #28245: [SPARK-31472][CORE] Make
sure Barrier Task always return messages or exception with abortableRpcFuture
check
URL: https://github.com/apache/spark/pull/28245#discussion_r410265189
##########
File path: core/src/main/scala/org/apache/spark/rpc/RpcEndpointRef.scala
##########
@@ -114,11 +114,9 @@ private[spark] class RpcAbortException(message: String)
extends Exception(messag
* A wrapper for [[Future]] but add abort method.
* This is used in long run RPC and provide an approach to abort the RPC.
*/
-private[spark] class AbortableRpcFuture[T: ClassTag](
- future: Future[T],
- onAbort: String => Unit) {
+private[spark] class AbortableRpcFuture[T: ClassTag](f: Future[T], onAbort:
Throwable => Unit) {
- def abort(reason: String): Unit = onAbort(reason)
+ def abort(t: Throwable): Unit = onAbort(t)
- def toFuture: Future[T] = future
+ def future: Future[T] = f
Review comment:
`toFuture` sounds like it's going to create a new future whereas it isn't.
So I changed to `future`. @WeichenXu123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
