rdblue commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax
URL: https://github.com/apache/spark/pull/28026#issuecomment-615322877
 
 
   > EXTERNAL doesn't give you useful information IMO
   
   Hive allows EXTERNAL with LOCATION and without it. Spark would be preventing 
EXTERNAL tables with a default location in Hive, which is perfectly valid to a 
Hive catalog. Your opinion that it is not useful doesn't mean it isn't a 
feature that Hive supports. This would be Spark deciding what a specific 
catalog can do.
   
   > Are we going to tell end-users that these are just two different ways to 
specify some configs and the catalog is free to interpret them?
   
   Yes. I don't see much of a benefit to either making sure OPTIONS and 
TBLPROPERTIES don't conflict as long as we document how OPTIONS are added.
   
   If you're concerned about conflicts between OPTIONS and SERDEPROPERTIES, 
then I think it would be reasonable to ensure that only one is used in a SQL 
statement because these are from different flavors of CREATE TABLE. I also 
don't think it is likely that anyone would use both, given how nested 
SERDEPROPERTIES is in the parser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to