turboFei commented on a change in pull request #28239: [SPARK-31467][SQL][TEST]
Refactor the tests in hive/SQLQuerySuite to prevent TableAlreadyExistsException
URL: https://github.com/apache/spark/pull/28239#discussion_r410795468
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -974,47 +995,57 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils
with TestHiveSingleton {
}
test("SPARK-5203 union with different decimal precision") {
- Seq.empty[(java.math.BigDecimal, java.math.BigDecimal)]
- .toDF("d1", "d2")
- .select($"d1".cast(DecimalType(10, 5)).as("d"))
- .createOrReplaceTempView("dn")
+ withTempView("dn") {
+ Seq.empty[(java.math.BigDecimal, java.math.BigDecimal)]
+ .toDF("d1", "d2")
+ .select($"d1".cast(DecimalType(10, 5)).as("d"))
+ .createOrReplaceTempView("dn")
- sql("select d from dn union all select d * 2 from dn")
- .queryExecution.analyzed
+ sql("select d from dn union all select d * 2 from dn")
+ .queryExecution.analyzed
+ }
}
test("Star Expansion - script transform") {
- assume(TestUtils.testCommandAvailable("/bin/bash"))
- val data = (1 to 100000).map { i => (i, i, i) }
- data.toDF("d1", "d2", "d3").createOrReplaceTempView("script_trans")
- assert(100000 === sql("SELECT TRANSFORM (*) USING 'cat' FROM
script_trans").count())
+ withTempView("script_trans") {
+ assume(TestUtils.testCommandAvailable("/bin/bash"))
+ val data = (1 to 100000).map { i => (i, i, i) }
+ data.toDF("d1", "d2", "d3").createOrReplaceTempView("script_trans")
+ assert(100000 === sql("SELECT TRANSFORM (*) USING 'cat' FROM
script_trans").count())
+ }
}
test("test script transform for stdout") {
- assume(TestUtils.testCommandAvailable("/bin/bash"))
- val data = (1 to 100000).map { i => (i, i, i) }
- data.toDF("d1", "d2", "d3").createOrReplaceTempView("script_trans")
- assert(100000 ===
- sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat' AS (a,b,c) FROM
script_trans").count())
+ withTempView("script_trans") {
+ assume(TestUtils.testCommandAvailable("/bin/bash"))
+ val data = (1 to 100000).map { i => (i, i, i) }
+ data.toDF("d1", "d2", "d3").createOrReplaceTempView("script_trans")
+ assert(100000 ===
+ sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat' AS (a,b,c) FROM
script_trans").count())
+ }
}
test("test script transform for stderr") {
- assume(TestUtils.testCommandAvailable("/bin/bash"))
- val data = (1 to 100000).map { i => (i, i, i) }
- data.toDF("d1", "d2", "d3").createOrReplaceTempView("script_trans")
- assert(0 ===
- sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat 1>&2' AS (a,b,c) FROM
script_trans").count())
+ withTempView("script_trans") {
+ assume(TestUtils.testCommandAvailable("/bin/bash"))
+ val data = (1 to 100000).map { i => (i, i, i) }
+ data.toDF("d1", "d2", "d3").createOrReplaceTempView("script_trans")
+ assert(0 ===
+ sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat 1>&2' AS (a,b,c) FROM
script_trans").count())
+ }
}
test("test script transform data type") {
- assume(TestUtils.testCommandAvailable("/bin/bash"))
- val data = (1 to 5).map { i => (i, i) }
- data.toDF("key", "value").createOrReplaceTempView("test")
- checkAnswer(
- sql("""FROM
- |(FROM test SELECT TRANSFORM(key, value) USING 'cat' AS (`thing1`
int, thing2 string)) t
- |SELECT thing1 + 1
+ withTempView("test") {
+ assume(TestUtils.testCommandAvailable("/bin/bash"))
+ val data = (1 to 5).map { i => (i, i) }
+ data.toDF("key", "value").createOrReplaceTempView("test")
+ checkAnswer(
+ sql("""FROM
+ |(FROM test SELECT TRANSFORM(key, value) USING 'cat' AS
(`thing1` int, thing2 string))
Review comment:
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
