Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78614976
I certainly agree that binary compatibility matters. I think it's mainly a
question of which is more desirable: fewer repeated LOC or binary
compatibility.
I can write new methods for each of the approaches to PPR, but it would
require repeating a lot of the pregel boilerplate. If you feel strongly
that's a better approach, I'm happy to make the change.
On Thu, Mar 12, 2015 at 1:40 PM, Sean Owen <[email protected]> wrote:
> Yes but binary compatibility also matters. I can't see the Jenkins output
> anymore, but I recall thinking it was probably legitimate. Can you write
> this differently without optional args maybe?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/4774#issuecomment-78606657>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
