Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/4844#issuecomment-78631713
  
    I like this. It is tightening visibility only on Spark-private classes, so 
there should be no API impact. MiMa doesn't report problems, except:
    
    - I think the `MavenCoordinate` warning is spurious since it's an inner 
class of a private class. Worth double-checking and if it's unclear, it could 
be left declared `private[...]` itself
    - Isn't `PythonRunner` technically public? but one of its methods was made 
`private`. Hm. Also worth double-checking and backing out if it's not obviously 
safe
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to